New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added examples and docs for nft mint, send, burn #532

Merged

thibault-martinez merged 30 commits into iotaledger:develop from anistark:docs/sdk-nft

Jun 26, 2023

Contributor

anistark commented Jun 3, 2023

Description of change

Added docs for nft mint, send, burn.
Also renamed a file with spell fix.

Links to any relevant issues

Part of issue #415

Type of change

Choose a type of change, and delete any options that are not relevant.

Documentation Fix

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation


          added nft mint, send, burn

anistark requested a review from Dr-Electron

June 3, 2023 17:04

anistark added 4 commits

June 3, 2023 22:36


          removed walletdb

a1fc8e4


          removed lock file

d7787a5


          added example-walletdb to gitignore

2c25e0f


          added example-walletdb to gitignore

2cb5285

Thoralf-M reviewed

View reviewed changes

bindings/nodejs/examples/how_tos/nfts/burn_nft.ts Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bindings/nodejs/examples/how_tos/nfts/burn_nft.ts Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bindings/nodejs/examples/how_tos/nfts/send_nft.ts Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bindings/nodejs/examples/how_tos/nfts/send_nft.ts Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bindings/nodejs/examples/how_tos/nfts/mint_nft.ts Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bindings/nodejs/examples/wallet/10-mint-nft.ts Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bindings/python/examples/how_tos/nfts/mint_nft.py Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

bindings/python/examples/how_tos/nfts/send_nft.py Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

documentation/sdk/docs/how_tos/nfts/01_mint_nft.mdx Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

documentation/sdk/docs/how_tos/nfts/01_mint_nft.mdx Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

documentation/sdk/docs/how_tos/nfts/02_send_nft.mdx Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

documentation/sdk/docs/how_tos/nfts/03_burn_nft.mdx Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

documentation/sdk/docs/how_tos/nfts/03_burn_nft.mdx Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/examples/how_tos/nfts/burn_nft.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/examples/how_tos/nfts/mint_nft.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/examples/how_tos/nfts/mint_nft.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/examples/how_tos/nfts/send_nft.rs Outdated Show resolved Hide resolved

Contributor

Dr-Electron commented Jun 3, 2023

Format check for nodejs bindings is failing :)

anistark and others added 6 commits

June 4, 2023 16:09


          Update bindings/nodejs/examples/how_tos/nfts/burn_nft.ts

067fbc4

Co-authored-by: Thoralf-M <[email protected]>


          Update bindings/nodejs/examples/how_tos/nfts/burn_nft.ts

ccb8b47

Co-authored-by: Thoralf-M <[email protected]>


          Update bindings/nodejs/examples/how_tos/nfts/send_nft.ts

fb9c527

Co-authored-by: Thoralf-M <[email protected]>


          Update bindings/nodejs/examples/how_tos/nfts/send_nft.ts

fe53c09

Co-authored-by: Thoralf-M <[email protected]>


          Update bindings/python/examples/how_tos/nfts/mint_nft.py

025aa1b

Co-authored-by: Thoralf-M <[email protected]>


          Update bindings/python/examples/how_tos/nfts/send_nft.py

51d0e34

Co-authored-by: Thoralf-M <[email protected]>


          removing commented code

9d5ff33

luca-moser linked an issue

that may be closed by this pull request

Create NFTs examples with related docs #415

Closed

8 tasks

thibault-martinez requested changes

View reviewed changes

Member

thibault-martinez left a comment

Conflicts

Member

thibault-martinez commented Jun 21, 2023

Is this still being worked on?

Contributor Author

anistark commented Jun 21, 2023

Is this still being worked on?

Yes. Stuck on building Python bindings.

Member

thibault-martinez commented Jun 21, 2023

How can we help?

Contributor

Dr-Electron commented Jun 22, 2023

Can we merge it anyway? I mean the example works, right? And building python bindings is something we should discuss in another issue or somewhere else. That way this example isn't blocked as most should run it with the released pypi package anyway

Member

thibault-martinez commented Jun 22, 2023

Sure

Member

Thoralf-M commented Jun 22, 2023

There are still 2 unresolved comments (and a conflict)

anistark added 3 commits

June 22, 2023 15:15


          Merge branch 'develop' into docs/sdk-nft

281ecef


          removed example files

ce23e28


          updated rust examples to updated sync

d430033

Thoralf-M reviewed

View reviewed changes

sdk/examples/how_tos/nfts/mint_nft.rs Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/examples/how_tos/nfts/burn_nft.rs Outdated Show resolved Hide resolved

anistark added 2 commits

June 22, 2023 17:21


          removed comment

0e82469


          added back account sync

9cc8d1a

Thoralf-M requested changes

View reviewed changes

Member

Thoralf-M left a comment

Please format Rust and nodejs, then I will approve


          formatted

41e6e4d

Thoralf-M previously approved these changes

View reviewed changes

thibault-martinez requested changes

View reviewed changes

Member

thibault-martinez left a comment

yarn.lock is back in the gitignore


          removed yarn.lock

ccfeb81

anistark dismissed Thoralf-M’s stale review via

ccfeb81

June 26, 2023 08:05

Thoralf-M previously approved these changes

View reviewed changes

thibault-martinez reviewed

View reviewed changes

sdk/examples/how_tos/nfts/send_nft.rs Outdated Show resolved Hide resolved

sdk/examples/how_tos/nfts/mint_nft.rs Outdated Show resolved Hide resolved

sdk/examples/how_tos/nfts/burn_nft.rs Outdated Show resolved Hide resolved


          Apply suggestions from code review

fba44ca

thibault-martinez dismissed Thoralf-M’s stale review via

fba44ca

June 26, 2023 08:09

thibault-martinez approved these changes

View reviewed changes

Thoralf-M approved these changes

View reviewed changes

thibault-martinez merged commit b328a0d into iotaledger:develop

18 of 20 checks passed

anistark deleted the docs/sdk-nft branch

June 26, 2023 09:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet